Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DES-2182: Questionnaire viewer #118

Merged
merged 16 commits into from
Jun 9, 2023
Merged

DES-2182: Questionnaire viewer #118

merged 16 commits into from
Jun 9, 2023

Conversation

duckonomy
Copy link
Contributor

@duckonomy duckonomy commented Jan 2, 2023 •
edited
Loading

Overview:

Make basic .rq asset type importable.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Testing Steps:

  1. Run corresponding hazmapper DES-2182: Questionnaire asset type geoapi#112
  2. Import .rq file from test project

UI Photos:

Screen Shot 2023-04-12 at 7 18 58 AM

Screen Shot 2023-04-12 at 7 10 41 AM

Notes:

Compressed questionnaire types are not supported in this pr.

@duckonomy duckonomy mentioned this pull request Jan 2, 2023
Merged
3 tasks
nathanfranklin
nathanfranklin reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we merge to a feature branch and follow-on work goes there? or some in this PR? whatever you think 👍

Also, what should we show above the "Show Questionaire" button. maybe this is a follow-up item for when we get the assets added.

angular/src/app/utils/questionnaireBuilder.ts Outdated Show resolved Hide resolved
angular/src/app/utils/questionnaireBuilder.ts Outdated Show resolved Hide resolved
angular/src/app/components/modal-questionnaire-viewer/modal-questionnaire-viewer.component.styl Show resolved Hide resolved
angular/src/app/components/modal-questionnaire-viewer/modal-questionnaire-viewer.component.ts Outdated Show resolved Hide resolved
nathanfranklin
nathanfranklin approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Left one text change to consider.

Just two things we should put in a new Jira issue:

  • what do we show above the "view questionnaire" button in the asset window.
  • what css changes can we make to make the font size and spacing a little better in the questionnaire viewer.

angular/src/app/utils/questionnaireBuilder.ts Outdated Show resolved Hide resolved
sophia-massie
sophia-massie approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nathanfranklin nathanfranklin merged commit 382f9af into master Jun 9, 2023
@nathanfranklin nathanfranklin deleted the task/DES-2182-questionnaire-viewer branch June 9, 2023 21:36
@nathanfranklin nathanfranklin mentioned this pull request Oct 6, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophia-massie sophia-massie sophia-massie approved these changes

@nathanfranklin nathanfranklin nathanfranklin approved these changes

@taoteg taoteg Awaiting requested review from taoteg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duckonomy @nathanfranklin @sophia-massie