Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MediaStore files table. #1306

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Add support for MediaStore files table. #1306

merged 1 commit into from
Aug 31, 2024

Conversation

oupson
Copy link
Contributor

@oupson oupson commented Aug 31, 2024

This add support for qoi and jxl.

This add support for qoi and jxl.
@T8RIN
Copy link
Owner

T8RIN commented Aug 31, 2024

Thanks! Is it doesn't work without MANAGE_EXTERNAL_STORAGE tho? Because your POC jxl gallery didn't request this

@oupson
Copy link
Contributor Author

oupson commented Aug 31, 2024

Thanks! Is it doesn't work without MANAGE_EXTERNAL_STORAGE tho? Because your POC jxl gallery didn't request this

It is requested : https://github.com/oupson/Jxl-Gallery/blob/031790ae2378818d9f0171ab610ab84d47b7f25d/app/src/main/AndroidManifest.xml#L18.

It doesn't work without that.

@T8RIN
Copy link
Owner

T8RIN commented Aug 31, 2024

As i remember it's special permission which i need to allow all files managing, but for some reason when i open it just requesting photo reading permission

@oupson
Copy link
Contributor Author

oupson commented Aug 31, 2024

I think it's when there is requestLegacyExternalStorage on the manifest

@T8RIN
Copy link
Owner

T8RIN commented Aug 31, 2024

Interesting, this flag works only on Android 10, so also does your solution not load this files if permission given only for photos?

@oupson
Copy link
Contributor Author

oupson commented Aug 31, 2024

I dont have a telephone to try on android < 10.

I think it wont work if the user does not give the permission

@T8RIN
Copy link
Owner

T8RIN commented Aug 31, 2024

even don't work without jxl and qoi images? I mean if user didn't give MANAGE_EXTERNAL_STORAGE permission, will query return at least simple pictures which are not require this?

@oupson
Copy link
Contributor Author

oupson commented Aug 31, 2024

Yes, without giving this permission this app will have the same behavior as before, only showing what android think is video or pictures.

Android don't recognize jxl or qoi as image file but as simple files and you need manage external storage to access such files

@T8RIN
Copy link
Owner

T8RIN commented Aug 31, 2024

Okay thanks! I'll merge it

@T8RIN T8RIN merged commit c32cbc5 into T8RIN:master Aug 31, 2024
1 check passed
@T8RIN
Copy link
Owner

T8RIN commented Aug 31, 2024

And last question, this media retriever works only on Android 8 and above, what can i do, to support down to 5 or at least 6 ?

@oupson
Copy link
Contributor Author

oupson commented Aug 31, 2024

And last question, this media retriever works only on Android 8 and above, what can i do, to support down to 5 or at least 6 ?

I dont know, but I will try to put my hand on an old device and try next week

@T8RIN
Copy link
Owner

T8RIN commented Aug 31, 2024

Okay, thanks a lot 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants