Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS / Geo-Location data lost on edit #654

Closed
foss- opened this issue Jan 11, 2024 · 13 comments
Closed

GPS / Geo-Location data lost on edit #654

foss- opened this issue Jan 11, 2024 · 13 comments

Comments

@foss-
Copy link

foss- commented Jan 11, 2024

Reproduce

  1. select Draw for an image with GPS data
  2. enable Keep EXIF option so that metadata is kept
  3. draw on image
  4. tap disc icon to save image
  5. see confirmation dialog

Currently

When looking at the edited image, the GPS data is gone.

Expected

All metadata should be kept.

@T8RIN
Copy link
Owner

T8RIN commented Jan 11, 2024

Check image source in the options, it gives info about geo

@foss-
Copy link
Author

foss- commented Jan 11, 2024

Thanks for the response. When I open Settings > Image source I see Photo picker selected. Since that option mentions Has issues receiving EXIF metadata I switched to Gallery and repeated above steps but saved image still has no GPS data.

@T8RIN
Copy link
Owner

T8RIN commented Jan 11, 2024

Hm, even with last option?

@foss-
Copy link
Author

foss- commented Jan 11, 2024

Third option File explorer works and keeps the GPS metadata 🎉
This is very helpful, been wondering about this for a long time.

Would it make sense to remember the EXIF setting last used? My personal use-case requires this to be on, but it is always off when I go into editing.

@T8RIN
Copy link
Owner

T8RIN commented Jan 11, 2024

Hm, i can add an additional setting if you want :)

@foss-
Copy link
Author

foss- commented Jan 11, 2024

Not sure how this is best handled. Follow last used state avoids an additional settings option and my be sufficient. Certainly a setting is also possible - not sure which section would fit and adding yet another section to settings would make them even more crowded so not a fan. But if you have an existing category in mind sure.

@T8RIN
Copy link
Owner

T8RIN commented Jan 11, 2024

In the additional exif category, i prefer this way because it's much easier to implement 👀

@foss-
Copy link
Author

foss- commented Jan 11, 2024

Sure, you're the boss and since I can't code happy either way 🚀

Do you want a separate issue for that feature request?

EDIT: #655

@T8RIN
Copy link
Owner

T8RIN commented Jan 11, 2024

Yup, that's would be great 💯

@T8RIN T8RIN closed this as completed Jan 11, 2024
@foss-
Copy link
Author

foss- commented Jan 17, 2024

Retested 2.6.0a2 and still struggling to keep EXIF information after using draw with an image.

  • Keep EXIF option is enabled
  • Image Source is File explorer

And yet the edited image has no GPS information while the original has GPS information.

@foss-
Copy link
Author

foss- commented Jan 20, 2024

Persisting in 2.6.0a3. Could you re-open this issue? Sadly none of the three image source options allows to keep the GPS information in the image when saving a draw edit. The timestamp was kept with all three options.

This feels like a problem in Android behavior.

Found a similar issue filed against Nextcloud and fm-sys pointed out that Stripping EXIF data is part of the android Q privacy feature set. Starting with Android 10 (or 11?), apps need to explicitly specify that they want to receive Metadata..

If you'd be willing to take a look how to specifically request to receive EXIF data when opening an image, that might solve this issue.

In comment nextcloud/android#6248 (comment) there are also three links about the behavior which are:

@T8RIN T8RIN reopened this Jan 21, 2024
@T8RIN
Copy link
Owner

T8RIN commented Jan 21, 2024

Thanks, i will check

@T8RIN
Copy link
Owner

T8RIN commented Jan 23, 2024

I did this i think, checked with latest image source and location not lost on android 14 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants