fix: Support Nexus 1.0.0 (#182) #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to work just fine in one of my projects that was updated to nexus 1.0.0 ! |
|
Thanks for that, I will pull it locally just to make sure. I think it might warrant a minor version upgrade instead of a fix. |
Closed
|
@Sytten did you want to release this with a minor version bump or are you still waiting for other features / bugfixes ? |
|
Sorry for the delay I had a rough week and enjoying some time off. I will finish everything tomorrow. |
|
Fixed by #190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the package name and changed
RootValuetoSourceValueand all tests are passing !Could it be this simple ?!