Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter identities to compute import scopes #348

Merged
merged 27 commits into from
Jul 20, 2023
Merged

Conversation

dcolleoni
Copy link
Contributor

@dcolleoni dcolleoni commented Jul 17, 2023

Allow in CsmToIfrsVar to filter out identities which should not be computed in csm.

Default pattern to CU amountType when pattern is not found.

Log validation if pattern is not found

dcolleoni added 16 commits July 6, 2023 14:35
# Conflicts:
#	ifrs17/Constants/Enums.ipynb
#	ifrs17/Import/1ImportScope-Identities.ipynb
#	ifrs17/Import/2ImportScope-PresentValue.ipynb
#	ifrs17/Import/3ImportScope-Actuals.ipynb
#	ifrs17/Import/4ImportScope-TechnicalMargin.ipynb
#	ifrs17/Import/5ImportScope-ToIfrsVar.ipynb
#	ifrs17/Report/ReportScopes.ipynb
#	ifrs17/Utils/ImportCalculationMethods.ipynb
@dcolleoni dcolleoni added the import related to importing label Jul 17, 2023
@dcolleoni dcolleoni added this to the v1.4.0 milestone Jul 17, 2023
@dcolleoni dcolleoni self-assigned this Jul 17, 2023
@dcolleoni dcolleoni requested a review from dtrzesniak July 19, 2023 15:29
ifrs17/Constants/Validations.ipynb Outdated Show resolved Hide resolved
ifrs17/Import/2ImportScope-PresentValue.ipynb Show resolved Hide resolved
ifrs17/Import/4ImportScope-TechnicalMargin.ipynb Outdated Show resolved Hide resolved
ifrs17/Utils/ImportCalculationMethods.ipynb Show resolved Hide resolved
ifrs17/Import/5ImportScope-ToIfrsVar.ipynb Show resolved Hide resolved
ifrs17/Import/5ImportScope-ToIfrsVar.ipynb Outdated Show resolved Hide resolved
@dcolleoni dcolleoni merged commit f8c3cb5 into develop Jul 20, 2023
@dcolleoni dcolleoni deleted the FilterOnIdToCompute branch July 20, 2023 08:24
@dcolleoni dcolleoni linked an issue Aug 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import related to importing
Projects
Status: Done
2 participants