Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PeakRDL plugin to use base class #1

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Update PeakRDL plugin to use base class #1

merged 1 commit into from
Mar 13, 2023

Conversation

amykyta3
Copy link
Member

As you might have seen, I reworked how PeakRDL handles plugins slightly.
Starting in v0.7.0, all importer & exporter plugin descriptor classes now have to be derived off of a base class.
This is something I initially hesitated to do, but after a while found it cumbersome to not have proper class inheritance here.
Unfortunately this kinda breaks compatibility, but hey this is all beta stuff so far anyways and I was bound to change my mind on these things 😉

This PR addresses the compatibility change.

@MarekPikula
Copy link
Member

Thank you for the change 😃

Besides, would you be interested in pulling this plugin to the SystemRDL namespace? It would be pretty nice to have it properly "upstreamed".

@MarekPikula MarekPikula merged commit f6de6dc into SystemRDL:main Mar 13, 2023
@amykyta3
Copy link
Member Author

amykyta3 commented Mar 14, 2023

Yes always interested in more useful tools to be added!
A few questions:

  • Does your markdown plugin work on py3.6 and py3.7? Sure these are pretty old versions, however it is not uncommon for people to be stuck with an older python version in their workplace. For that reason, I strive to keep compatibility back to py3.6 for all the other PeakRDL tools.
  • Would you be willing to move the repository to the SystemRDL organization (and join the group)? You would retain all existing permissions & ownership as before.

@MarekPikula
Copy link
Member

  1. Python 3.7 is supported (though not from 3.7.0, but 3.7.2). I think it was because some development dependency required version ≥3.7.2, but it should be easy to change down to 3.6. As far as I recall, I didn't use any advanced features, so it's not an issue as well. I'll check today.
  2. Sure, that would be great.

@MarekPikula
Copy link
Member

Actually, now I checked, and many development dependencies (including pytest) require Python ≥3.7.0. So I could go as low as 3.7.0, but I'm afraid that no lower than that, as I would have no means to execute reliable tests in CI (here, I'm using pytest). Would that work for you? Anyway, which LTS distro uses Python 3.6?

@amykyta3
Copy link
Member Author

I sent you an invite. Once added you should be able to move the repository.

I'm using pytest all the way down to 3.5 without issues.
Ubuntu 18.04 = py3.6
Ubuntu 16.04 = py3.5
Both distributions are under extended maintenance for still a few more years. Similar for CentOS as well.

I wouldn't worry about the version stuff too much. Should be pretty straightforward to back-fill support.

@MarekPikula
Copy link
Member

I just noticed that you sent me the invite. It must have missed it in the inbox. Could you resend it?

@MarekPikula MarekPikula mentioned this pull request May 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants