Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combine glycolysis + gluconeogenesis #251

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

BenjaSanchez
Copy link
Contributor

@BenjaSanchez BenjaSanchez commented Oct 5, 2020

Main improvements in this PR:

Both glycolysis and gluconeogenesis correspond to only one KEGG pathway, but for some reason they were stored as separated groups, probably because the name has a / character in it, which might have been interpreted as a separation at some point. Tested an I/O cycle and nothing changes, so the bug was probably introduced manually and should not re-appear.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)

@BenjaSanchez BenjaSanchez added the bug something is wrong in the model label Oct 5, 2020
@BenjaSanchez BenjaSanchez requested a review from feiranl October 5, 2020 12:25
@BenjaSanchez BenjaSanchez self-assigned this Oct 5, 2020
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@BenjaSanchez BenjaSanchez removed the request for review from hongzhonglu October 5, 2020 13:54
@BenjaSanchez BenjaSanchez merged commit 27350d4 into devel Oct 6, 2020
@BenjaSanchez BenjaSanchez deleted the fix/gluconeogenesis branch October 6, 2020 09:17
This was referenced Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is wrong in the model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants