-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/growth check #244
Feat/growth check #244
Conversation
return warning if model either cannot grow or the simulation is unfeasible
to avoid displaying text when using anaerobicModel
warnings can be used during development, but errorring will be enforced in new releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Work perfectly!
@BenjaSanchez @edkerk However, I noticed that our saving function is very heavy, which takes over 4mins. I am not sure which function took so long, is that possible to improve this? |
@Feiran You can run |
@edkerk thanks for the suggestion, @feiranl see below that from the ~5 mins it takes in my computer, more than 4 mins are taken by |
Main improvements in this PR:
After discussion in #242,
saveYeastModel
now checks if the model can grow under aerobic/anaerobic conditions, and returns warnings if not (based on a low threshold) or if the simulation turns unfeasible. If theallowNoGrowth
flag is set to false, then instead it will error; this latter option is now used byincreaseVersion
when making new releases.I hereby confirm that I have:
devel
as a target branch (top left drop-down menu)