Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/growth check #244

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Feat/growth check #244

merged 5 commits into from
Aug 14, 2020

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

After discussion in #242, saveYeastModel now checks if the model can grow under aerobic/anaerobic conditions, and returns warnings if not (based on a low threshold) or if the simulation turns unfeasible. If the allowNoGrowth flag is set to false, then instead it will error; this latter option is now used by increaseVersion when making new releases.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)

return warning if model either cannot grow or the simulation is unfeasible
to avoid displaying text when using anaerobicModel
warnings can be used during development, but errorring will be enforced in new releases
@BenjaSanchez BenjaSanchez added the enhancement new field/feature label Aug 10, 2020
@BenjaSanchez BenjaSanchez requested review from edkerk and feiranl August 10, 2020 14:25
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Work perfectly!

@feiranl
Copy link
Collaborator

feiranl commented Aug 13, 2020

@BenjaSanchez @edkerk However, I noticed that our saving function is very heavy, which takes over 4mins. I am not sure which function took so long, is that possible to improve this?

@edkerk
Copy link
Member

edkerk commented Aug 13, 2020

@Feiran You can run profile on; saveYeastModel(model); profile viewer to see how which parts of a function (and it's subfunctions) take the longest.

@BenjaSanchez
Copy link
Contributor Author

BenjaSanchez commented Aug 13, 2020

@edkerk thanks for the suggestion, @feiranl see below that from the ~5 mins it takes in my computer, more than 4 mins are taken by writeSBML, which is the COBRA function for saving the .xml file. On our side saveYeastModel itself only takes 11 seconds, and RAVEN's exportForGit takes 30 seconds (most of it by writeYaml for saving the .yml file).

image

@BenjaSanchez BenjaSanchez merged commit 8e795ba into devel Aug 14, 2020
@BenjaSanchez BenjaSanchez deleted the feat/growth-check branch August 14, 2020 08:48
@BenjaSanchez BenjaSanchez mentioned this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new field/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants