-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/pip tools #235
Feat/pip tools #235
Conversation
to easily keep track of the original requirements. Also build requirements.txt from requirements.in and adapt README accordingly.
same as user requirements but also with pip-tools
@mihai-sysbio would this scheme fit with the |
Looks good to me! Two suggestions:
You have your
This will use the pinned versions of your basic requirements. Sometimes you may need to play with the path, i.e., it might need to be |
Another thought I have is related to the current identity between |
simplified setup
* don't re-list stuff * enforce same dependencies
In fact it already provides me with value, as I've been switching between my |
@BenjaSanchez coming back to your original question on dealing with requirements in |
@mihai-sysbio currently we require the |
standards 👍 |
Main improvements in this PR:
A problem with storing python dependencies as
requirements.txt
is that there's no way of distingushing between actual dependencies and transitive dependencies (i.e dependencies of the actual dependencies). For that purpose, Here we switch to use pip-tools: All original dependencies are stored inrequeriments.in
, and usingpip-compile
we generate therequirements.txt
file to bepip install
'ed (or evenpip-sync
'ed via pip-tools). Additionally,dev-requirements.in
is provided for developers (same as the other file but also with pip-tools). This scheme also allows even more environments to be implemented later on (for instanceci-requirements.in
for the memote implementation, so that it only installs the minimum packages for the test suite).@Midnighter I borrowed this structure from some of the DeCaF microservices, let me know if it makes sense to you. @hongzhonglu any other useful package that users need and I'm forgetting in
requirements.in
?I hereby confirm that I have:
devel
as a target branch (top left drop-down menu)