Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/change folder names #234

Closed
wants to merge 2 commits into from
Closed

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

This partly addresses #232 by changing folder names to be compliant with MetabolicAtlas/standard-GEM.

Note that:

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)

to comply with new naming convention
@BenjaSanchez BenjaSanchez added format fix things associated to format of any of the model/data/script files standby work somewhere else is needed before advancing labels Jun 26, 2020
@BenjaSanchez BenjaSanchez requested a review from edkerk June 26, 2020 10:57
@BenjaSanchez BenjaSanchez self-assigned this Jun 26, 2020
@BenjaSanchez BenjaSanchez removed the request for review from edkerk June 26, 2020 11:15
@BenjaSanchez BenjaSanchez marked this pull request as draft June 26, 2020 11:15
@BenjaSanchez
Copy link
Contributor Author

BenjaSanchez commented Jun 26, 2020

@edkerk I was too quick with this one: before reviewing maybe we should first settle on the model folder issue in #232 and also merge #228 to avoid conflicts :)

@BenjaSanchez BenjaSanchez deleted the chore/change-folder-names branch June 29, 2020 08:41
@BenjaSanchez BenjaSanchez removed the standby work somewhere else is needed before advancing label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format fix things associated to format of any of the model/data/script files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant