Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug for MNX rxn ID in notes field #226

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Fix the bug for MNX rxn ID in notes field #226

merged 4 commits into from
Jun 23, 2020

Conversation

feiranl
Copy link
Collaborator

@feiranl feiranl commented Jun 4, 2020 •
edited
Loading

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

@feiranl feiranl requested a review from BenjaSanchez June 4, 2020 18:46
@feiranl feiranl mentioned this pull request Jun 4, 2020
Closed
4 tasks
@BenjaSanchez BenjaSanchez added the bug something is wrong in the model label Jun 15, 2020
BenjaSanchez
BenjaSanchez reviewed Jun 15, 2020
View reviewed changes
Copy link
Contributor

@BenjaSanchez BenjaSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! While you are correcting the MNX ids, you can also add all the SEED/RHEA/BiGG ids to the proper annotation fields, see below for the model field names.

ModelFiles/dependencies.txt Outdated Show resolved Hide resolved
ModelFiles/xml/yeastGEM.xml Outdated Show resolved Hide resolved
ModelFiles/xml/yeastGEM.xml Outdated Show resolved Hide resolved
ModelFiles/xml/yeastGEM.xml Outdated Show resolved Hide resolved
@BenjaSanchez BenjaSanchez added the wip work in progress label Jun 15, 2020
@BenjaSanchez BenjaSanchez mentioned this pull request Jun 22, 2020
Open
4 tasks
@BenjaSanchez BenjaSanchez removed the wip work in progress label Jun 22, 2020
@BenjaSanchez BenjaSanchez merged commit af02d9a into devel Jun 23, 2020
@BenjaSanchez BenjaSanchez deleted the fix-MNXbug branch June 23, 2020 08:21
@BenjaSanchez BenjaSanchez mentioned this pull request Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaSanchez BenjaSanchez BenjaSanchez approved these changes

Assignees
No one assigned
Labels
bug something is wrong in the model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feiranl @BenjaSanchez