-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-rxn-prop:addNewGPRrelations #124
Conversation
add database new gene annotation files
Add new GPR relations for existing reactions
no content changes
* geneName = geneID when geneName in SGD DB has no match or is empty * should be "COBRAProtein"
Structurally it looks fine, but it would good to see a brief description on how these GPRs were decided. Doesn't have to be very detailed, but now this is entirely unclear. Can be mentioned in this PR, or could have been in commit messages, but now it is not mentioned anywhere. |
@edkerk the reasoning behind each change can be found in |
As discussed, please provide a short description of where the information regarding gene annotations is coming from, by editing the original pull request message. |
change column title for the DBNewGeneAnnotation
@feiranl could you check 'YAR073W', which may be pseudogene? We should remove gene like this to make sure the quality. |
YAR0723W , YIL168W and YIL167W are not functional
delete three non functional genes and changed the related GPR rules
Delete unsed 3 genes using cobra function:model = removeUnusedGenes(model)
@feiranl @hongzhonglu any remaining changes? if none I will merge in the afternoon. |
@BenjaSanchez No changes from my side. |
@BenjaSanchez No changes from my side. |
Main improvements in this PR:
Addresses issue #60
I hereby confirm that I have:
devel
as a target branch (top left drop-down menu)