-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new reactions based on latest gene annotation #38
Comments
@hongzhonglu looks good to me. Some additional comments:
|
@BenjaSanchez Very good suggestion! For issues #11, #18, #37, I have nearly completed them. I will share with you later. For issue #38, it mainly used to improve model coverage. To make the update clear, I put these items together, so that everyone could understand it clearly. Let us do it step by step. |
@feiranl @BenjaSanchez @edkerk |
EC 2.7.11.1 is a protein kinase, and these kind of enzymes would fall outside of the scope of a purely metabolic model (which is what Yeast7 is and Yeast8 still will be?). So you can leave out GPRs where the reaction is a protein-modifying reaction (kinase, phosphatase, ubiquitine ligase, etc.). Any other questionable ones? |
Great thanks! Yeast8 will be a purely metabolic model, so we can excluded some genes. Will let you know if I find other doubted genes. |
@BenjaSanchez @edkerk @feiranl @zhengmingzhu |
@BenjaSanchez @edkerk @feiranl @zhengmingzhu |
@elsemman Thanks for your remind. So we can use it directly. |
@ALL, this issue will be focus on adding new GPRs based on model merge and latest genome annotation as @BenjaSanchez suggested. So it will be clear for us to tack it. |
As @elsemman mentioned, addRxns from RAVEN can be used for this. Please use release 2.0.0-rc.1 A few points:
|
@edkerk Thanks for the detailed comments! Presently, I have evaluate each reaction connected with new gene but not for each metabolite in these reactions. We can further check these metabolites and screen the new metabolites compared with present model. |
@hongzhonglu what do you mean here by "model merge"? I thought that was already included in issue #13? |
@hongzhonglu also the part of "genome annotation" I thought was already covered by issue #60. So it looks that this issue is redundant. If so could we close it? |
@BenjaSanchez This issue can be focused on addition of new GPRs based on the 5 different database! This part is on going now. |
@hongzhonglu I see, then this issue focuses on adding whereas issue #60 focuses on correcting. I have renamed both issues to reflect this, just make sure of committing separately when you address each one of the issues. Cheers! |
update: PR #142 added all new rxns to |
Solved in Yeast8 |
@edkerk @BenjaSanchez , Dear both, in next phase, I want to focus on adding new GPRs into model. The followed is the detailed step:
The text was updated successfully, but these errors were encountered: