Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correction of gene relation for transport reactions #160

Closed
4 tasks done
hongzhonglu opened this issue Sep 12, 2018 · 4 comments · Fixed by #321
Closed
4 tasks done

fix: correction of gene relation for transport reactions #160

hongzhonglu opened this issue Sep 12, 2018 · 4 comments · Fixed by #321
Assignees
Labels
fixed in devel this issue is already fixed in devel and will be closed after the next release

Comments

@hongzhonglu
Copy link
Collaborator

hongzhonglu commented Sep 12, 2018

When compared with the gene annotation in database of SGD and uniprot, it could be found that there
are multiple errors in the gene relations for transport reaction, such as the genes for r_1101, r_1133. Thus, we need to correct them.
The transport rxn list need to be checked:
r_1101
r_1133
r_1173
r_1183
r_1238

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Done this analysis in the master branch of the repository
  • Checked that a similar issue does not exist already
  • If needed, asked first in the Gitter chat room about the issue
@BenjaSanchez
Copy link
Contributor

@hongzhonglu could you provide the entire list of errors here? How many rxns are there in total with issues?

@BenjaSanchez BenjaSanchez changed the title Correction of gene relation for transport reactions from original yeast 7.6 fix: correction of gene relation for transport reactions Sep 12, 2018
@hongzhonglu
Copy link
Collaborator Author

@BenjaSanchez I am preparing the rxn list with gene errors now. Will put it here when i complete the check.

@BenjaSanchez
Copy link
Contributor

@hongzhonglu is this a repetition of issue #171? If so we can close this one

@hongzhonglu
Copy link
Collaborator Author

@BenjaSanchez This issue is mainly used to correct the genes relation for transport reactions with gene associations while issue #171 is to add genes for transport reactions without gene associations.

@edkerk edkerk added the fixed in devel this issue is already fixed in devel and will be closed after the next release label May 28, 2022
@edkerk edkerk mentioned this issue Jun 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in devel this issue is already fixed in devel and will be closed after the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants