Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAVEN 2.8.7 #524

Merged
merged 6 commits into from
Feb 24, 2024
Merged

RAVEN 2.8.7 #524

merged 6 commits into from
Feb 24, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Feb 14, 2024

Main improvements in this PR:

  • Fix:
    • ftINIT could have removed metabolites that are required for specific tasks.
    • importModel allows SBML without a specified objective function (this is not valid SBML, but will be tolerated).
    • Swap soplex with scip as solver. The soplex option introduced in release 2.8.5 should not be used for MILP, scip is dedicated for these problems. Precompiled binaries for Windows are provided (downloaded upon request), further installation instructions are mentioned in the Wiki.
    • ravenCobraWrapper properly makes comps and compNames fields when lacking in COBRA model.
    • writeYAMLmodel can deal with mixture of nested and not-nested cell arrays of subsystems (as COBRA models can have).
    • extractMiriam should allow cell array of multiple miriamNames as input.
    • checkInstallation correctly makes binaries executable on Ubuntu (solves bug: make binaries executable on Ubuntu #527)
  • Refactor:
    • Reduce the default verbosity and number of messages to the command window for a few functions.

I hereby confirm that I have:

  • Selected main as a target branch

* fix: ftINIT do not remove exch metabolites

they might be required for a task, does not affect final model

* fix: importModel allows SBML without obj

Is strictly not valid SBML, but import will be supported anyway.

* refactor: reduce default verbosity

* doc: update issue and PR templates
* fix: ravenCobraWrapper variations on cobra fields

* chore: updateDocumentation
@edkerk edkerk added this to the 2.8.7 milestone Feb 14, 2024
Copy link

github-actions bot commented Feb 14, 2024

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 > Installing from location             /home/m/actions-runner/_work/RAVEN/RAVEN
> Checking RAVEN release DEVELOPMENT
> Checking MATLAB release 2020b
> Checking system architecture glnxa64
> Set RAVEN in MATLAB path Pass
> Save MATLAB path Pass
> Make binaries executable Pass

> Add Java paths for Excel format Pass
> Checking libSBML version 5.19.0
> Checking model import and export
> Import Excel format Pass
> Export Excel format Pass
> Import SBML format Pass
> Export SBML format Pass

> Checking for LP solvers
> glpk Pass
> gurobi Pass
> scip Fail
> cobra Pass
> Set RAVEN solver gurobi

> Checking BLAST+ Pass
> Checking DIAMOND Pass
> Checking HMMER Pass

> Checking function uniqueness Pass

*** checkInstallation complete ***

Running blastPlusTests
.
Done blastPlusTests

Running cdhitTests
.
Done cdhitTests

Running checkTasksTests
.
Done checkTasksTests

Running diamondTests
.
Done diamondTests

Running fillGapsLargeTests
..
Done fillGapsLargeTests

Running fillGapsSmallTests
...
Done fillGapsSmallTests

Running hmmerTests
.
Done hmmerTests

Running importExportTests
....
Done importExportTests

Running mafftTests
.
Done mafftTests

Running miriamTests
.
Done miriamTests

Running modelAbilitiesTests
........
Done modelAbilitiesTests

Running modelConversionTests
.
Done modelConversionTests

Running modelCurationTests
.......... ........
Done modelCurationTests

Running modelSortingTests
..
Done modelSortingTests

Running solverTests
..
Error occurred in solverTests/testSCIP and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using solverTests>testSCIP (line 80)
SCIP MEX binary not installed or not functional, test skipped
..
Done solverTests

Running tinitTests
..........
Done tinitTests

Failure Summary:

Name Failed Incomplete Reason(s)
=====================================================
solverTests/testSCIP X X Errored.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit 695b6b4 into main Feb 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant