-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable adding prefix 'M_' and 'R_' in exprotModel function #356
Conversation
To my opinion, |
Also, I suggest this would be part of a minor release (2.5.2 -> 2.6.0). It might break compatibility of scripts that would have relied on the identifiers having their prefix removed, and full COBRA <-> RAVEN compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to have this fix in Raven. I noted a few things
- in
io/exportModel.m:510
this should be updatedrdf:about="#meta_R_' model.rxns{i} '"
- not compulsory: there's a reference to
meta_M
indoc/io/exportModel.html:391
and tometa_R
in the same file on line569
-
I think @edkerk noted that there is no function that reports all SBML-invalid identifiers, which I agree should be part of this PR that solves refactor: remove prefix 'M_' and 'R_' in exprotModel/importModel functions #353see below
On second thought, @edkerk would it be okay to resolve the concern above as a different PR, to keep PRs small and targeted? This PR will then resolve only a part of #353, which makes sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove line 225-231, where
c_
is appended tomodel.comps
.
the html files will be corrected by the |
As far as I can see |
We have the routine to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successful I/O of yeast-GEM
.
Here I merge this since |
Main improvements in this PR:
exportModel
function to stop adding by prefixM_
andR_
to metabolite and reactions ids, as proposed in refactor: remove prefix 'M_' and 'R_' in exprotModel/importModel functions #353I hereby confirm that I have:
devel
as a target branch