Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GPR curation for transport reactions (5) #955

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JHL-452b
Copy link
Collaborator

Main improvements in this PR:

As proposed in #920 and #921 :

  • Remove ENSG00000165029 from MAR00215;
  • Remove ENSG00000165029 from MAR00231;
  • Remove ENSG00000165029 from MAR00239;
  • Remove ENSG00000165029 from MAR00269;
  • Remove ENSG00000165029 from MAR00277;
  • Remove ENSG00000165029 from MAR00287;
  • Remove ENSG00000165029 from MAR00351;
  • Remove ENSG00000021488 from MAR01902;
  • Remove ENSG00000021488 from MAR01904;
  • Remove ENSG00000205060 from MAR04125;
  • Remove ENSG00000108932 from MAR04935;
  • Remove ENSG00000103257 from MAR05467;
  • Remove ENSG00000165029 from MAR05540;
  • Remove ENSG00000103257 from MAR05575;
  • Remove ENSG00000103257 from MAR05588;
  • Remove ENSG00000103064 from MAR05606;
  • Remove ENSG00000102743 from MAR06314;
  • Remove ENSG00000125454 from MAR07827;
  • Remove ENSG00000125454 from MAR07836;
  • Remove ENSG00000125454 from MAR07844;
  • Remove ENSG00000100170 from MAR11410;
  • Remove ENSG00000165970 from MAR11456;
  • Remove ENSG00000173638 from MAR11647;
  • Remove ENSG00000142583 from MAR11779;
  • Remove ENSG00000103064 from MAR05608;
  • Remove ENSG00000103064 from MAR05615;
  • Remove ENSG00000103064 from MAR05627;
  • Remove ENSG00000103064 from MAR05640;
  • Remove ENSG00000103064 from MAR05653;
  • Remove ENSG00000103064 from MAR05659;
  • Remove ENSG00000103064 from MAR05675;
  • Remove ENSG00000103064 from MAR05686;
  • Remove ENSG00000103064 from MAR05690;
  • Remove ENSG00000103064 from MAR05696;
  • Remove ENSG00000103064 from MAR05717;
  • Remove ENSG00000103064 from MAR05720;
  • Remove ENSG00000103064 from MAR05734;
  • Remove ENSG00000103064 from MAR05741;
  • Remove ENSG00000103064 from MAR05742;
  • Remove ENSG00000103064 from MAR05744;
  • Remove ENSG00000103064 from MAR05749;
  • Remove ENSG00000103064 from MAR05766;
  • Remove ENSG00000103064 from MAR05787;
  • Remove ENSG00000103064 from MAR05799;
  • Remove ENSG00000103064 from MAR05801;
  • Remove ENSG00000103064 from MAR05810;
  • Remove ENSG00000103064 from MAR05811;
  • Remove ENSG00000103064 from MAR05815;
  • Remove ENSG00000103064 from MAR05825;
  • Remove ENSG00000103064 from MAR05831;
  • Remove ENSG00000103064 from MAR05856;
  • Remove ENSG00000103064 from MAR05998;

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link

This PR has been automatically tested with GH Actions. Here is the output of the MACAW test:

Starting dead-end test...
- Found 1523 dead-end metabolites.
- Found 1328 reactions incapable of sustaining steady-state fluxes in either direction due to these dead-ends.
- Found 1975 reversible reactions that can only carry steady-state fluxes in a single direction due to dead-ends.
Starting duplicate test...
- Skipping redox duplicates because no redox_pairs and/or proton_ids were provided.
- Found 447 reactions that were some type of duplicate:
- 0 were completely identical to at least one other reaction.
- 13 involve the same metabolites but go in the opposite direction or have the opposite reversibility as at least one other reaction.
- 447 involve the same metabolites but with different coefficients as at least one other reaction.

This and a more detailed output from MACAW are also committed to data/macawResults/.

Note: In the case of multiple test runs, this post will be edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant