Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store summary macaw results #882

Merged
merged 4 commits into from
Nov 5, 2024
Merged

feat: store summary macaw results #882

merged 4 commits into from
Nov 5, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Oct 18, 2024

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@edkerk edkerk force-pushed the feat/macaw_output branch 2 times, most recently from 208710d to 6c85278 Compare October 18, 2024 16:00
@edkerk edkerk requested a review from feiranl October 18, 2024 16:14
@edkerk edkerk force-pushed the feat/macaw_output branch from 8be690d to b3560db Compare October 18, 2024 18:45
@edkerk edkerk force-pushed the feat/macaw_output branch from b3560db to cd98819 Compare October 18, 2024 18:59
@edkerk
Copy link
Member Author

edkerk commented Oct 19, 2024

Also contains some preparations in data/testResults/README.md for including gene essentiality results (#675)

edkerk and others added 2 commits October 28, 2024 20:30
# Conflicts:
#	.github/workflows/macaw-tests.yml
#	data/testResults/README.md
@SysBioChalmers SysBioChalmers deleted a comment from github-actions bot Oct 28, 2024
@SysBioChalmers SysBioChalmers deleted a comment from github-actions bot Oct 28, 2024
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feiranl feiranl merged commit f2320fd into develop Nov 5, 2024
@edkerk edkerk deleted the feat/macaw_output branch November 5, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants