-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GPRs of mitochondrial beta-oxidation reactions with peroxisomal genes #726
Conversation
…d peroxisomal genes in them
Tests are failing cuz after changing all of those GPRs, ACAD10 ( According to Uniprot, ACAD11 is known to catalyze Uniprot says ACAD10 can only act on (R)- and (S)-2-methyl-pentadecanoyl-CoA, citing this paper, which clarified that, while those were the only substrates they observed ACAD10 to act on, the activity was low enough that they doubted either was the main substrate in vivo. I can't seem to find any other papers that ever showed that ACAD10 can act on anything else; should I just remove it from the model altogether, or figure out how many other reactions I'd need to add to connect 2-methyl-pentadecanoyl-CoA to the rest of the network? |
based on the evidence provided, it seems that ACAD10 should be removed from the model |
Modification of 100+ GPRs is too big to be implemented at once, because it is error-prone in making changes and hard to review, and should be avoided in future. |
Tremendous work @Devlin-Moyer! I will have a look at this in the following days (and agree with @haowang-bioinfo, a big chunk to digest at once), but maybe let's start with moving |
I believe the work of this PR is commendable and truly impressive, yet I must express some concerns regarding the current state. As it stands, the PR appears quite extensive and complex, posing a challenge for effective review and integration in a single session. As reviewers, we have a responsibility to the community to uphold the quality of the model. Over time, without thorough checks, the model could degrade from unchecked changes. To facilitate a more effective and pragmatic review process for this PR, there might be two possible options:
|
I went back through all of the reactions whose GPRs I edited here and I found that a lot of them had other problems that seemed like they merited separate issues, so I've updated #634 to have a much shorter list of reactions and also tried to add a bit more information that hopefully makes it easier for y'all to fact check it; I'm gonna close this PR now |
thanks |
Main improvements in this PR:
Updates all GPRs mentioned in #634
Since those GPR changes would leave ACAD11 (
ENSG00000240303
) associated with no reactions, also:MAR03107
andMAR03111
PMID:21237683
to lists of references forMAR03107
andMAR03111
I hereby confirm that I have:
develop
as a target branch