fix: refine animal GEM updating pipeline #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- These gene names are now padded with empty elements, this is fine but not a decent way
- Previously, the only option is to set biomass to MAR00021, now the option of reusing MAR13082 from HumanGEM is provided
Co-authored-by: Mihail Anton <[email protected]>
mihai-sysbio
approved these changes
Aug 17, 2023
- This is to resolve recurring issue reported in #511
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
This PR improves animal GEM updating pipeline:
geneShortNamesfield (introduced by add gene name to Human-GEM #539) by padding with empty elements in functionaddMetabolicNetworkupdateAnimalGEMwith option of reusing Human-GEM biomass equationI hereby confirm that I have:
developas a target branch