Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Ammonium/Ammonia Duplicates Into Single Reactions #677

Merged
merged 5 commits into from
Jul 21, 2023
Merged

Merge Ammonium/Ammonia Duplicates Into Single Reactions #677

merged 5 commits into from
Jul 21, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

Main improvements in this PR:

Makes changes proposed in #665:

  • Removes MAR01515 for being a duplicate of MAR08529
  • Removes MAR00039 for being a duplicate of MAR07992
  • Removes MAR00096 for being a duplicate of MAR04819
  • Removes MAR02027 for being a duplicate of MAR04302
  • Removes MAR02006 for being a duplicate of MAR03873
    In cases where the removed reaction had references the kept reaction didn't, those references were added to the kept reaction's references, and likewise for IDs from older models in model/reactions.tsv

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@Devlin-Moyer Devlin-Moyer requested a review from feiranl July 16, 2023 14:03
feiranl
feiranl approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feiranl feiranl merged commit 2dc4b63 into develop Jul 21, 2023
@Devlin-Moyer Devlin-Moyer deleted the fix/ammonium-ammonia_duplicates branch July 28, 2023 13:23
@Devlin-Moyer Devlin-Moyer mentioned this pull request Aug 1, 2023
Closed
6 tasks
@haowang-bioinfo haowang-bioinfo mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiranl feiranl feiranl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Devlin-Moyer @feiranl