Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate metabolites identified by ChEBI IDs(2) #667

Merged
merged 3 commits into from
Jun 25, 2023
Merged

Fix duplicate metabolites identified by ChEBI IDs(2) #667

merged 3 commits into from
Jun 25, 2023

Conversation

JHL-452b
Copy link
Collaborator

Main improvements in this PR:

As discussed in #627

  • change BiGG ID annotations for MAM02679e, MAM02579c, MAM02579m, MAM02579e, MAM02579r, MAM02579n, MAM02579x, MAM02043c, MAM03887x
  • replace met
old ID new ID
MAM03231c MAM03232c

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@JHL-452b JHL-452b closed this Jun 25, 2023
@feiranl feiranl reopened this Jun 25, 2023
feiranl
feiranl approved these changes Jun 25, 2023
View reviewed changes
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feiranl feiranl merged commit c958319 into SysBioChalmers:develop Jun 25, 2023
@haowang-bioinfo
Copy link
Member

@all-contributors please add @JHL-452b for bug report.

@allcontributors allcontributors bot mentioned this pull request Jun 26, 2023
Merged
@allcontributors
Copy link
Contributor

@haowang-bioinfo

I've put up a pull request to add @JHL-452b! 🎉

@haowang-bioinfo haowang-bioinfo mentioned this pull request Aug 13, 2023
Closed
2 tasks
@haowang-bioinfo haowang-bioinfo mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiranl feiranl feiranl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JHL-452b @haowang-bioinfo @feiranl