Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate metabolites identified by PubChem IDs(2) #662

Merged
merged 6 commits into from
Jun 26, 2023

Conversation

JHL-452b
Copy link
Collaborator

Main improvements in this PR:

As discussed in #622

  • remove rxns MAR04506
  • change KEGG ID annotations for MAM01230c, MAM02676c, MAM02676m, MAM02676r, MAM02676e, MAM02647x, MAM03021m, MAM03021x, MAM00531c, MAM00531n, MAM02678c, MAM02678m, MAM02678x, MAM02678r, MAM02679e
  • replace mets
old ID new ID
MAM03540c MAM01729c
MAM03540e MAM01729e

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feiranl feiranl merged commit bd93f0e into SysBioChalmers:develop Jun 26, 2023
@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented Jun 26, 2023

@feiranl it seems this PR introduced bug into Yaml file that started to fail in import/export cycle, better fix it before further merging

@feiranl
Copy link
Collaborator

feiranl commented Jun 26, 2023

@feiranl it seems this PR introduced bug into Yaml file that started to fail in import/export cycle, better fix it before further merging

This bug was caused by the missing two lines in the newly added met, which was introduced by the merging develop branch into this feature branch. This bug has been fixed in #649

@haowang-bioinfo
Copy link
Member

yes, very good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants