Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Reactions With Same Stoichiometry But Different Genes #657

Merged
merged 12 commits into from
Jul 6, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

@Devlin-Moyer Devlin-Moyer commented Jun 20, 2023

Main improvements in this PR:

Implements changes initially proposed in #580 and recently mentioned again in #630:

  • Removes MAR02358 for being a duplicate of MAR08482
  • Makes MAR08482 reversible Have compartment-specific GPRs for MAR08482 and MAR03931
  • Removes MAR20066 for being a duplciate of MAR03984
  • Removes MAR20020 for being a duplicate of MAR04521
  • Removes MAR20002 for being a duplicate of MAR06631
  • Removes MAR00030 for being a duplicate of MAR00025
  • Merges annotations, references, E.C. codes, etc. from removed reactions into kept reactions
  • Updates rxnRetired column for kept reactions in reactions.tsv

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@Devlin-Moyer
Copy link
Collaborator Author

I'm reasonably confident that the YAML validation failed because MAR00030 was the only reaction that ENSG00000072310, ENSG00000100979, and ENSG00000138823 were associated with; should I just go ahead and remove those genes as well? None of them appear to be enzymes, since MAR00030 wasn't really a "real" metabolic reaction.

@Devlin-Moyer Devlin-Moyer requested a review from feiranl June 20, 2023 23:43
@mihai-sysbio
Copy link
Member

There's a pending PR that could be merged to develop which would add printing of the errors, thus increasing the certainty. Not sure how urgent this PR is - waiting a bit might help.

@Devlin-Moyer
Copy link
Collaborator Author

It's not urgent, and while that would be nice, using this

import cobra
model = cobra.io.load_yaml_model('model/Human-GEM.yml')
[m.id for m in model.metabolites if len(m.reactions) == 0]
[g.id for g in model.genes if len(g.reactions) == 0]

was pretty easy; the first list was empty and the second one was exactly the list of genes I mentioned above

@Devlin-Moyer Devlin-Moyer changed the title Fix/same stoich diff gpr dupes Merge Reactions With Same Stoichiometry But Different Genes Jun 27, 2023
model/Human-GEM.yml Outdated Show resolved Hide resolved
model/Human-GEM.yml Outdated Show resolved Hide resolved
- keep MAR08482 irreversible
- keep compartment specific genes for MAR08482 and MAR03931
@haowang-bioinfo haowang-bioinfo merged commit d1ba2c7 into develop Jul 6, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/same_stoich_diff_gpr_dupes branch July 6, 2023 16:55
@Devlin-Moyer Devlin-Moyer mentioned this pull request Jul 28, 2023
3 tasks
@haowang-bioinfo haowang-bioinfo mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants