Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate metabolites identified by BiGG IDs #646

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Fix duplicate metabolites identified by BiGG IDs #646

merged 6 commits into from
Jun 26, 2023

Conversation

JHL-452b
Copy link
Collaborator

Main improvements in this PR:

As discussed in #610

  • remove mets MAM03226m, MAM03884c, MAM03884e, MAM03554c for being duplicates
  • remove rxns MAR00042,MAR01617, MAR00740, MAR00659, MAR05323, MAR01709 for being affected by duplicate mets
  • change BiGG ID annotations for MAM01746c, MAM00078x, MAM02328c, MAM02328g, MAM02328l, MAM02328e, MAM02328r, MAM02008c, MAM02008g, MAM02008l, MAM02008e
  • replace mets
old ID new ID
MAM03884x MAM02746x

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@feiranl feiranl changed the title Fix bi gg Fix duplicate metabolites identified by BiGG IDs Jun 18, 2023
feiranl
feiranl approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@JHL-452b JHL-452b mentioned this pull request Jun 21, 2023
Closed
4 tasks
@feiranl feiranl mentioned this pull request Jun 23, 2023
Merged
3 tasks
feiranl
feiranl approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feiranl feiranl merged commit dbcee94 into SysBioChalmers:develop Jun 26, 2023
@haowang-bioinfo haowang-bioinfo mentioned this pull request Sep 25, 2023
Merged
This was referenced Jan 2, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiranl feiranl feiranl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JHL-452b @feiranl