-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-add a error report in the import/export cycle #629
Conversation
@haowang-bioinfo Could you help to fix this? I add an error catch, but the task still succeed. |
looks good - the actual cause is now fixed in 182010d Regarding the pass of One practical solution (that I used sometimes) could be locally running |
- The changes in this commit are to move subsystem reading code into the "case" of reading confidence_score. This optimise the logic of loading subSystems according the Yaml file structure.
I'm confused - the test is now successful. Is that right? My idea was to start by fixing the test first, so that we can confirm that the test will trigger a failure of the GH workflow. Only after that the yaml problem would be fixed, and the re-run of the workflow would then pass. |
I renamed the branch to |
Absolutely! It was not the intention to close the PR, sorry about that. Normally branch renaming is seamless, but apparently when a PR is already open, GitHub will close it. Let's continue in #635. |
yes indeed, working on this now |
this bug is located from Yaml file line 307295: another bug introduced from #606 was the met id |
- This commit includes fixing typos, and reverting back to original way of extracting subsystem values
this PR is reopened for fixing yaml import/export cycle only, while the issue of GH workflow test will be fixed in #635 |
LGTM! The import and export cycle works fine now |
Main improvements in this PR:
This PR is to fix only the bug found in Yaml file, as reported in #628. In the meantime, another PR #635 is to fix error of GH workflow test