Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fatal importYaml bug #619

Merged
merged 2 commits into from
Jun 8, 2023
Merged

fix: fatal importYaml bug #619

merged 2 commits into from
Jun 8, 2023

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Jun 7, 2023

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@edkerk edkerk requested a review from feiranl June 7, 2023 14:50
@haowang-bioinfo haowang-bioinfo requested review from feiranl and removed request for feiranl June 7, 2023 14:57
Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well with R2021a

@feiranl
Copy link
Collaborator

feiranl commented Jun 8, 2023

Works perfectly with R2022b

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feiranl feiranl merged commit e146e2b into develop Jun 8, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/importYaml branch June 9, 2023 18:18
This was referenced Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants