-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: miscellaneous curations #325
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
86320d9
fix: change perxisome compartment abbreviation from "p" to "x"
haowang-bioinfo 9897c06
fix: resolve identical mets in both sides of MAR04499
haowang-bioinfo a6b078d
fix: add CHEBI xref to MAM00003
haowang-bioinfo fb981b0
fix: add new CHEBI ids as suggested in #300
haowang-bioinfo 082f865
fix: correct xref for MAM02679, as discussed in #297
haowang-bioinfo 1a824e5
fix: add back BiGG id `ptth` that is correctly associated
haowang-bioinfo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the associated
metBiGGIDptthremoved? I think that association was correct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,
ptthdoes appear to be correctly annotated in BiGG.This removal was due to the wrong annotation to
metRecon3DIDidptth, which probably should be removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, very interesting case - so the
ptthentry is correct in BiGG but incorrect in VMH. Although I would like to maintain the association with the Recon3D ID, it may be better to remove it to avoid confusion...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is.
Now the BiGG id was added back, while the erroneous Recon3D id excluded.