Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: annotation for MAM03165c #312

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

ANiknejad
Copy link
Contributor

see issue #310

@haowang-bioinfo
Copy link
Member

@ANiknejad please modify this PR by changing the target branch from SysBioChalmers:main to SysBioChalmers:develop

@mihai-sysbio mihai-sysbio changed the base branch from main to develop September 3, 2021 15:30
@mihai-sysbio mihai-sysbio changed the title Develop fix: annotation for MAM03165c Sep 4, 2021
@JonathanRob
Copy link
Collaborator

The only change here is to the metabolites.tsv file, yet the "YAML validation" check is failing... why is that? @mihai-sysbio or @Hao-Chalmers.

@haowang-bioinfo
Copy link
Member

It's strange that the error message is Gene annotation mismatch!, but this PR has nothing to do with genes ...

@mihai-sysbio
Copy link
Member

Previously, I have encountered cases where aggressive caching led to workflow failures. As expected, running this check locally returns:

All checks have passed.

After having requested several re-runs of this workflow leading to failures, I would be okay with merging as-is.

@haowang-bioinfo haowang-bioinfo merged commit 93fd9d1 into SysBioChalmers:develop Sep 6, 2021
This was referenced Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants