Fix localized Chrome's extension id

[piotrfrankowski]

Motivation and context

In localized Chrome version extension would be reported as Identifier: ID instead of just an ID. This fix handles that behavior

Does it fix any issue?

setupMetamask would hang as there will be no metamaskPage in commands/playwright

Other useful info

Tested with Chrome 116 and 118 (arm)

Quality checklist

• I have performed a self-review of my code.

[duckception]

Hey, thanks for the PR! ❤️

Never would've thought this could be an issue but glad that you managed to find it and fix it!

One question:

• I'm currently in a position where I'm not able to check this behavior myself. Could you post a screenshot from localized Chrome that shows the "extension" box? To do this go to chrome://extensions, then in the top right corner click "Developer mode" or equivalent, and make a screenshot like this one:
  

Regarding your PR, wouldn't the fix for this issue be more straightforward if we just made a minor change to the line 485 in metamask.js?

Changing this:

const extensionId = (
  await extensionData.locator('#extension-id').textContent()
).replace('ID: ', ''); // Line 485

To this:

const extensionId = (
  await extensionData.locator('#extension-id').textContent()
).replace(': ', ''); // Line 485

Let me know what you think 🫡

[piotrfrankowski]

Hey, that's making more sense to be honest, I'll update the PR

[duckception]

CI passed ✅

[duckception]

@piotrfrankowski Hey, a new Sypress release with changes from this PR is available under the 3.7.2-beta.8 tag! ✨