Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unlock close popup #298

Merged
merged 2 commits into from
Dec 21, 2021
Merged

fix unlock close popup #298

merged 2 commits into from
Dec 21, 2021

Conversation

danivm
Copy link
Contributor

@danivm danivm commented Dec 21, 2021

Fix Metamask popups after unlock

The problem

When Metamask popup still open, some methods can fail.
importWallet and createWallet methods close popups well, but is missing in unlock.

Solution

Create new closeMetamaskPopup method and use it in importWallet, createWallet and unlock.

@drptbl
Copy link
Collaborator

drptbl commented Dec 21, 2021

@danivm Thanks for contribution! Looks great at first look. I will make sure to test it out today and merge after.

All Best,
Jakub.

@drptbl drptbl merged commit 23bb01f into Synthetixio:dev Dec 21, 2021
@drptbl
Copy link
Collaborator

drptbl commented Dec 21, 2021

Hey @danivm, it has been merged and released as @synthetixio/[email protected].

Thanks for contribution!

All Best,
Jakub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants