Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop transitively depending on Cypress #1100

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

hasparus
Copy link

@hasparus hasparus commented Feb 7, 2024

Hey! Firstly, thank you for Synpress. I've been using it for end-to-end tests of Subgraph Studio for a while already.

Motivation and context

Due to a design limitation in DefinitelyTyped, it doesn't support peerDependencies. This means that Synpress, even when used with Playwright, transitively depends on Cypress, and installs it for its users.

This is an issue, because installing Cypress means downloading a browser. It's not fast, and with it can fail with a socket timeout on flaky internet connections.

PRs that try to fix it get closed:

Does it fix any issue?

Not that I know of.

Quality checklist

  • I have performed a self-review of my code.

Due to a design limitation in DefinitelyTyped, it doesn't support
`peerDependencies`. This means that Synpress, even when used with
Playwright, transitively depends on Cypress, and installs it for
its users.

PRs that try to fix it get closed:

- DefinitelyTyped/DefinitelyTyped#67000 (review)
- DefinitelyTyped/DefinitelyTyped#44962

I moved `@types/testing-library__cypress` to `peerDependencies`.
Copy link

vercel bot commented Feb 7, 2024

@hasparus is attempting to deploy a commit to the Synpress Team on Vercel.

A member of the Team first needs to authorize it.

@drptbl
Copy link
Collaborator

drptbl commented Feb 20, 2024

Thanks for PR @hasparus! We're currently working on new version of synpress (currently in alpha) which already fixes mentioned issue. Nevertheless I will considering merging this to stable version of synpress asap. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants