fix: unnecessary rest api call done

Signed-off-by: Jakub Mucha <[email protected]>
Synthetixio · Oct 30, 2022 · f0ff8a8 · f0ff8a8
1 parent 39aa45c
commit f0ff8a8
Showing 1 changed file with 15 additions and 16 deletions.
diff --git a/helpers.js b/helpers.js
@@ -96,23 +96,22 @@ module.exports = {
     let response;
 
     try {
-      if (process.env.GITHUB_USERNAME && process.env.GITHUB_PAT) {
-        response = await axios.get(
-          'https://api.github.com/repos/metamask/metamask-extension/releases',
-          {
-            auth: {
-              username: process.env.GITHUB_USERNAME,
-              password: process.env.GITHUB_PAT,
-            },
-          },
-        );
-      } else {
-        response = await axios.get(
-          'https://api.github.com/repos/metamask/metamask-extension/releases',
-        );
-      }
-
       if (version === 'latest' || !version) {
+        if (process.env.GITHUB_USERNAME && process.env.GITHUB_PAT) {
+          response = await axios.get(
+            'https://api.github.com/repos/metamask/metamask-extension/releases',
+            {
+              auth: {
+                username: process.env.GITHUB_USERNAME,
+                password: process.env.GITHUB_PAT,
+              },
+            },
+          );
+        } else {
+          response = await axios.get(
+            'https://api.github.com/repos/metamask/metamask-extension/releases',
+          );
+        }
         filename = response.data[0].assets[0].name;
         downloadUrl = response.data[0].assets[0].browser_download_url;
         tagName = response.data[0].tag_name;