rutorrent: fix volume customization in installation procedure and package dependencies

[smaarn]

Description

This is fixing basically installation related concerns:

• When customizing the volume an invalid value was defined for the full path of the download location
• There were left over files from the previous PHP integration (5.6)
• Apache 2.4 dependency wasn't explicitely declared
• Watch dir configuration wasn't appropriately supported

Should fix #5668

Checklist

• Build rule all-supported completed successfully
• New installation of package completed successfully
• Package upgrade completed successfully (Manually install the package again)
• Package functionality was tested

Type of change

• Bug fix

[mreid-tt]

I tried doing a clean install in DSM 6 and setting a watch directory but got an error:

I don't know if this is a new error or something from before. Below are some of the logs:

/var/log/packages/rutorrent.log

2023/03/18 11:34:18	install rutorrent 3.10-14 Begin preinst
2023/03/18 11:34:18	Begin load_variables_from_file
2023/03/18 11:34:18	End load_variables_from_file
2023/03/18 11:34:18	Begin initialize_variables
2023/03/18 11:34:18	End initialize_variables
2023/03/18 11:34:18	===> Step preinst. STATUS=INSTALL USER=rutorrent GROUP=sc-download SHARE_PATH=/volume1/downloads
2023/03/18 11:34:18	Begin validate_preinst
2023/03/18 11:34:18	install rutorrent 3.10-14 End preinst ret=[1]
2023/03/18 11:34:18	install rutorrent 3.10-14 Begin /bin/rm -rf /volume1/@tmp/pkginstall
2023/03/18 11:34:18	install rutorrent 3.10-14 End /bin/rm -rf /volume1/@tmp/pkginstall ret=[0]

/var/log/synopkg.log

2023/03/18 11:34:18	install rutorrent 3.10-14 Begin preinst
2023/03/18 11:34:18	install rutorrent 3.10-14 End preinst ret=[1]
2023/03/18 11:34:18	install rutorrent 3.10-14 Begin /bin/rm -rf /volume1/@tmp/pkginstall
2023/03/18 11:34:18	install rutorrent 3.10-14 End /bin/rm -rf /volume1/@tmp/pkginstall ret=[0]
2023/03/18 11:34:18	install rutorrent 3.10-14 failed

[smaarn]

I tried doing a clean install in DSM 6 and setting a watch directory but got an error:

I don't know if this is a new error or something from before. Below are some of the logs:

/var/log/packages/rutorrent.log

2023/03/18 11:34:18	install rutorrent 3.10-14 Begin preinst
2023/03/18 11:34:18	Begin load_variables_from_file
2023/03/18 11:34:18	End load_variables_from_file
2023/03/18 11:34:18	Begin initialize_variables
2023/03/18 11:34:18	End initialize_variables
2023/03/18 11:34:18	===> Step preinst. STATUS=INSTALL USER=rutorrent GROUP=sc-download SHARE_PATH=/volume1/downloads
2023/03/18 11:34:18	Begin validate_preinst
2023/03/18 11:34:18	install rutorrent 3.10-14 End preinst ret=[1]
2023/03/18 11:34:18	install rutorrent 3.10-14 Begin /bin/rm -rf /volume1/@tmp/pkginstall
2023/03/18 11:34:18	install rutorrent 3.10-14 End /bin/rm -rf /volume1/@tmp/pkginstall ret=[0]

/var/log/synopkg.log

2023/03/18 11:34:18	install rutorrent 3.10-14 Begin preinst
2023/03/18 11:34:18	install rutorrent 3.10-14 End preinst ret=[1]
2023/03/18 11:34:18	install rutorrent 3.10-14 Begin /bin/rm -rf /volume1/@tmp/pkginstall
2023/03/18 11:34:18	install rutorrent 3.10-14 End /bin/rm -rf /volume1/@tmp/pkginstall ret=[0]
2023/03/18 11:34:18	install rutorrent 3.10-14 failed

@mreid-tt it's actually something which dates back from the previous versions which had gone through the cracks. Will push a fix in this MR in the coming minutes hours. Thanks for spotting.

EDIT: Updated the ETA (sorry but I realized that I needed to reset my dev environment)

[smaarn]

Converting to draft until I confirm that I've fixed the watch directory issue reported above.

[smaarn]

Flagged as draft as I spotted another bug with the watch directory (not actually configured appropriately)

[mreid-tt]

I've done a reinstall and the watch folder gets created. I added a torrent into it however but nothing downloaded. I looked at the settings and saw this:

I don't know if this is correct and I changed it to this:

The torrent in the folder however still has not downloaded so perhaps I'm not understanding the app's configs.

[mreid-tt]

Okay, it looks like we thought of the same thing... As an update the torrent in the watch folder eventually downloaded on its own so there was some delay but it should be good now.

[mreid-tt]

Regarding my other #5617 (comment), where we discussed:

In the resource file, the webservice section can be expanded to include the specific service type. For example it currently has "backend": 8 which means "PHP7.4" but doesn't specify the front end as in apache_php or nginx_php

Hey @mreid-tt

• I believe we do specify the type of the backend so I'm not sure what you meant by " doesn't specify the front end as in apache_php or nginx_php".

What I was trying to share was the recommended configuration for the Web Service in the DSM 7 developer guide. In it the following common keys are mandatory: service, display_name, type and php. Within the php profile, these keys are mandatory: profile_name, profile_desc, backend, user and group.

When I initially looked at your resource file I missed that the type was already present and set to "apache_php" so that was my mistake. All in all things are looking good to me.

[mreid-tt]

@smaarn, I can confirm that the last patch fixed the watch folder and torrent files added to it are automatically downloaded.

[voytec13]

Are there any plans to support nginx as a backend or Apache will remain as hard dependency for rutorrent installation?

[mreid-tt]

Are there any plans to support nginx as a backend or Apache will remain as hard dependency for rutorrent installation?

As has been stated before in this #5617 (comment), there are no explicit plans for this. As you have asked this before, I would suggest you open a new issue specifically requesting that the backend support nginx. That way it can be tracked and responded to formally.

@smaarn, based on your previous comment there would likely have to be a hard switch from Apache to nginx as the package dependencies cannot allow for an either/or scenario. This document may assist with possible testing configurations: NGINX PHP FPM RTORRENT