-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet: add dotnet 6.0 runtime #4976
Conversation
mk/spksrc.install-resources.mk
Outdated
ifeq ($(strip $(PLIST_TRANSFORM)),) | ||
PLIST_TRANSFORM= cat | ||
endif | ||
plist: install | ||
include ../../mk/spksrc.plist.mk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
just an FYI I reverted the
|
- depends on dotnet-runtime package (SynoCommunity#4976) - patch pwsh to use library path of dotnet-runtime
- depends on dotnet-runtime package (SynoCommunity#4976) - patch pwsh to use library path of dotnet-runtime
Hi there, any progress on this pull request? |
@picrap If you are interested in this package, you can download packages created by github build action (within 90 days since last build). |
I manually installed the generated
|
Indeed, the packages created by github build action are incomplete. My locally built packages are about 50MB and the libraries are installed into
dotnet executable is:
|
- fix use of PLIST.auto with spksrc.install-resources.mk - allow multiple files in digests with different urls (dist names)
dotnet 6.0.4 is just released (so you can update the script 😉) |
@picrap the build of dotnet-runtime packages is fixed, and updated to v6.0.4 |
And this totally works! Brilliant! (we’ll run a few tests to be sure) |
We have a problem loading native assemblies (which are in |
@picrap on which platform are you testing? (DSM Version, arch like x64/armv7/aarch64) What native assemblies are not found by the loader? I cannot see any runtime folder in the package. |
@hgy59 this is not dotnet package-related. The problem is when an application is built with native libraries ( So here is my sample case: we have a DSM7 with AMD64 architecture. We use the I’ll try tomorrow to override the |
@picrap probably you find a solution in dotnet/runtime#34711 (comment) |
Nailed it: it is related to a mount point (I run an app generated on my PC with a CIFS mount on DSM), so coyping everything in local (on the DSM) works. The |
Motivation: Introduce dotnet runtime as the new .NET 6 is an LTS version
Linked issues: #3892
Checklist
all-supported
completed successfullyRemarks
.net (former .net core) has limitted platform support.
not supported archs are:
armadaxp
andalpine
. from generic armv7 package as reported in dotnet: mark armadaxp and alpine as unsupported #4793 for Radarr and Jellyfin packages.Framework fixes and enhancements