Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python update to 2.7.15 #3628

Merged

Conversation

chickenandpork
Copy link
Member

Motivation: This is basically @ymartin59's #3552 but with:

  • builds successfully (I wasn't able to repro the problem is with python: 2.7.15 update with dependencies #3552)
  • rebased to latest SynoCommunity/spksrc/master
  • cross/python/PLIST is parameterized
  • updates to libsodium's patches used instead of rewriting
  • some text/descriptions slightly different (shouldn't affect build)
  • Apachev2 license is ASL2

The changes above are minimal, and reflect the kind of cleanup that @ymartin59 tends to do to mine anyhow :) So, honestly, I haven't really done anything to his work except redo it by hand, which can avoid maybe quotation marks that look like other quotes or something else.

Maybe the rebasing to recent version is what did it.

Linked issues: #3546

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Checked upgrade of 2.7.14-19 to 2.7.15-20

Basic in-place test is:

/var/packages/python/target/bin/python   -c 'import _ctypes; import lxml; import sqlite3; print("x");'

@ymartin59
Copy link
Contributor

@chickenandpork Thanks Allan. Looks great. You are correct when you wrote all Python 2 based applications have now to be rebuilt and published... That was in my plans since vulnerability alerts about "requests" in almost all "requirements.txt": https://github.com/SynoCommunity/spksrc/network/alerts

@chickenandpork
Copy link
Member Author

chickenandpork commented Feb 16, 2019 via email

@Safihre
Copy link
Contributor

Safihre commented Feb 17, 2019

So what is different from the other PR #3552? Looks exactly the same. Strange it builds now.

The only reason all packages need to be rebuild is the requests package vulnerability?

@chickenandpork
Copy link
Member Author

chickenandpork commented Feb 17, 2019 via email

@Safihre
Copy link
Contributor

Safihre commented Feb 19, 2019

@ymartin59 Did you actually read the vulnerability that was fixed in requests?
https://github.com/kennethreitz/requests/issues/4716

This is not something that requires republishing of all packages, as it requires a potential attacker to be able to perform man-in-the-middle attacks on networks.

@Safihre
Copy link
Contributor

Safihre commented Feb 23, 2019

Python 2.7.16 will come in the near future.
https://github.com/python/cpython/blob/2.7/Misc/NEWS.d/2.7.16rc1.rst

I am not sure if this will affect this PR.. I certainly hope not because users have been waiting for months to get the new SABnzbd and this is all blocked by this update.

@chickenandpork
Copy link
Member Author

chickenandpork commented Feb 23, 2019 via email

@Safihre
Copy link
Contributor

Safihre commented Feb 24, 2019

@chickenandpork this is a bit off topic: what email can I reach you on? I would also like to setup maybe a spk server. You can also reach me at [email protected] :)

@ymartin59 ymartin59 changed the title Python 2.7.15 per ymartin Python update to 2.7.15 Feb 25, 2019
@ymartin59 ymartin59 merged commit b2ec726 into SynoCommunity:master Feb 25, 2019
publicarray added a commit to publicarray/spksrc that referenced this pull request Apr 26, 2019
* upstream/master: (151 commits)
  Fix build of itools (usbmuxd) for arch 88f6281
  Fix compilation of cross/fuse for arch ppc853x
  Update templates
  mono: update to 5.18.0.240 (release) (SynoCommunity#3561)
  syncthing: update to 1.1.0 and go to 1.12
  syncthing: split up firewall ports more granularly
  ffmpeg: fix for qoriq (SynoCommunity#3655)
  [Sonarr] Update to v2.0.0.5301
  Update Sonarr for v3 upgrade compatibility
  [Lidarr] Update to v0.5.0583
  [Radarr] Update to v0.2.0.1293
  [Jackett] Update to v0.11.43
  homeassistant: update to 0.87.1 and generic installer and service (SynoCommunity#3462)
  sabnzbd: update to 2.3.7 (SynoCommunity#3555)
  python" update to 2.7.15 (SynoCommunity#3628)
  tvheadend: fixes on 4.2.8 (SynoCommunity#3623)
  framework: improve icon generation (SynoCommunity#3172)
  framework: fix DISTRIB_DIR recursive definition
  ffmpeg: fix GMP install prefix
  framework: new docker image based on Debian Stretch
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants