Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env call should be capitalised #5

Closed
williamrenfrew opened this issue Nov 6, 2019 · 3 comments · Fixed by #6
Closed

Env call should be capitalised #5

williamrenfrew opened this issue Nov 6, 2019 · 3 comments · Fixed by #6
Assignees
Labels

Comments

@williamrenfrew
Copy link
Member

$env = getenv('email');

Other getenv() calls are using EMAIL, does this need to be the same?

@willpower232
Copy link
Member

if its a problem, its been a problem since the package was initially created

@williamrenfrew
Copy link
Member Author

Yup, its in the 'if $to is an array' catch so probably little used, but if capitalisation does effect env vars then I feel it should be corrected.

@Josh-G
Copy link
Contributor

Josh-G commented Nov 6, 2019

@Josh-G Josh-G removed their assignment Nov 6, 2019
williamrenfrew added a commit that referenced this issue Nov 6, 2019
If sending an array of $to, the getenv check would potentially fail, in Linux, due to being case sensitive.

Resolves #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants