Skip to content
This repository has been archived by the owner on Aug 20, 2022. It is now read-only.

update from SuperBuild #201

Closed
wants to merge 12 commits into from
Closed

update from SuperBuild #201

wants to merge 12 commits into from

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Jul 8, 2022

closes #200

Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know if this does the trick. I cannot imagine, as it's still going to do the UPDATE.sh that you've just modified.

Also, an update will definitely fail without the -s switch.

I don't have the bandwidth to test this I'm afraid, which is why I thought we'd agree to just write a message with a recommendation. But if you can test it, and it works, I'm happy!

@paskino
Copy link
Contributor Author

paskino commented Jul 18, 2022

I tested this as in SyneRBI/SIRF-SuperBuild#747

@KrisThielemans
Copy link
Member

I strongly suggest to port some of this to the SIRf-SuperBuild repo, and in this repo just let UPDATE.sh error out with a message that tells users what to do. (i.e. update their local version of the SB, and execute its UPDATE.sh -s. Otherwise we will have to keep this repo up-to-date for the next one anyway.

However, in the SB, I'd rather keep the original INSTALL* files, and let those call the docker files. Reasons:

@paskino
Copy link
Contributor Author

paskino commented Aug 3, 2022

Especially the file names in the docker directory aren't very clear!

@KrisThielemans
Copy link
Member

Closing here as we won't keep the repo up-to-date. Ideas here are in
SyneRBI/SIRF-SuperBuild#755 and SyneRBI/SIRF-SuperBuild#758

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update_VM cannot update VM 3.2
2 participants