Include _small files #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, brainweb notebook uses `zoom_image` and `sed`. This causes problems across OS's and if STIR executables haven't been compiled. This can simply be solved by supplying the _small images.
|
So we expose stir.zoom-image already? If not, I think that'd be useful. We could then replace sed with some python code. I'd prefer that over adding more binary data
Kris
…________________________________
From: Richard Brown <[email protected]>
Sent: Friday, November 8, 2019 5:18:58 PM
To: CCPPETMR/SIRF_data <[email protected]>
Cc: Subscribed <[email protected]>
Subject: [CCPPETMR/SIRF_data] Include _small files (#3)
Currently, the BrainWeb.ipynb<https://github.com/CCPPETMR/SIRF-Exercises/blob/master/notebooks/Synergistic/BrainWeb.ipynb> notebook uses zoom_image and sed. This causes problems across different OS's and if STIR executables haven't been compiled.
This can simply be solved by supplying the _small images.
________________________________
You can view, comment on, or merge this pull request online at:
#3
Commit Summary
* Include _small files
File Changes
* A examples/Synergistic/brainweb/Amyloid_small.hv<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-0> (26)
* A examples/Synergistic/brainweb/Amyloid_small.v<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-1> (0)
* A examples/Synergistic/brainweb/FDG_small.hv<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-2> (26)
* A examples/Synergistic/brainweb/FDG_small.v<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-3> (0)
* A examples/Synergistic/brainweb/T1_small.hv<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-4> (26)
* A examples/Synergistic/brainweb/T1_small.v<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-5> (0)
* A examples/Synergistic/brainweb/T2_small.hv<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-6> (26)
* A examples/Synergistic/brainweb/T2_small.v<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-7> (0)
* A examples/Synergistic/brainweb/uMap_small.hv<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-8> (26)
* A examples/Synergistic/brainweb/uMap_small.v<https://github.com/CCPPETMR/SIRF_data/pull/3/files#diff-9> (0)
Patch Links:
* https://github.com/CCPPETMR/SIRF_data/pull/3.patch
* https://github.com/CCPPETMR/SIRF_data/pull/3.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#3>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABQRIHKUS2OKTTXVFNHXVI3QSWNQFANCNFSM4JK26W5Q>.
|
|
We don't currently expose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the BrainWeb.ipynb notebook uses
zoom_imageandsed. This causes problems across different OS's and if STIR executables haven't been compiled.This can simply be solved by supplying the
_smallimages.