Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to switch to use CMake's FindPython #313

Open
KrisThielemans opened this issue Jan 26, 2020 · 3 comments · May be fixed by #933
Open

Need to switch to use CMake's FindPython #313

KrisThielemans opened this issue Jan 26, 2020 · 3 comments · May be fixed by #933
Assignees
@paskino
Milestone
v4.0

Comments

@KrisThielemans
Copy link
Member

See SyneRBI/SIRF#504

For the SuperBuild, there's an additional problem that not all projects will use FindPython, so somehow we'll have to pass ${Python_EXECUTABLE} to PYTHON_EXECUTABLE. It's going to be messy...
@KrisThielemans KrisThielemans mentioned this issue Jan 26, 2020
Closed
@KrisThielemans KrisThielemans mentioned this issue Jun 12, 2020
Closed
@KrisThielemans KrisThielemans mentioned this issue Aug 11, 2020
Closed
@KrisThielemans KrisThielemans mentioned this issue Jan 15, 2021
Closed
@KrisThielemans KrisThielemans mentioned this issue Nov 8, 2021
Open
@KrisThielemans KrisThielemans modified the milestones: v3.4, v3.3 Apr 28, 2022
@paskino paskino modified the milestones: v3.4, v3.5 Jan 19, 2023
@KrisThielemans
Copy link
Member Author

SIRF PR was SyneRBI/SIRF#868

@KrisThielemans
Copy link
Member Author

Create Python_CMAKE_ARGS and probably define both Python_EXECUTABLE to PYTHON_EXECUTABLE

@KrisThielemans KrisThielemans modified the milestones: v3.5, v3.6 Jun 8, 2023
@KrisThielemans KrisThielemans modified the milestones: v3.6, v4.0 Feb 1, 2024
@KrisThielemans
Copy link
Member Author

This is now pretty urgent, as recent CMake claims this support will be removed.

I've checked for remaining packages using the outdated FindPythonInterp.cmake. There's only 2

@KrisThielemans KrisThielemans linked a pull request Oct 3, 2024 that will close this issue
Updated modules in find_package command for Python3 #933
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paskino paskino

Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Updated modules in find_package command for Python3 NicoleJurjew/SIRF-SuperBuild
2 participants
@KrisThielemans @paskino