Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: use FindPython as opposed to FindPythonLibs #655

Closed
KrisThielemans opened this issue Aug 11, 2020 · 1 comment
Closed

CMake: use FindPython as opposed to FindPythonLibs #655

KrisThielemans opened this issue Aug 11, 2020 · 1 comment
Milestone

Comments

@KrisThielemans
Copy link
Collaborator

Python support has changed dramatically in CMake, so we need to update our files

find_package(PythonInterp)
# find libraries and include files
# TODO would be better to use target_include_directories
FIND_PACKAGE(PythonLibs REQUIRED)
INCLUDE_DIRECTORIES(${PYTHON_INCLUDE_PATH})
FIND_PACKAGE(Numpy REQUIRED)

It would for instance enable pypy support since CMake 3.18.1 (https://cmake.org/cmake/help/v3.18/module/FindPython.html)

Unfortunately it means handling differences between PYTHON_EXECUTABLE and Python_EXECUTABLE, see also SyneRBI/SIRF-SuperBuild#313

@KrisThielemans
Copy link
Collaborator Author

This was done in #985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant