Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

petric: get_data fixes #32

Merged
merged 3 commits into from
Jul 2, 2024
Merged

petric: get_data fixes #32

merged 3 commits into from
Jul 2, 2024

Conversation

KrisThielemans
Copy link
Member

No longer read data upfront

Fixes #31

@KrisThielemans
git ignore output/ and other files
14e3dc3
@KrisThielemans
import petric no longer reads data
68756d4 
Set data_dirs_metrics, as opposed to calling get_data() for all datasets.

Fixes #31
@KrisThielemans KrisThielemans added the enhancement New feature or request label Jul 2, 2024
casperdcl
casperdcl requested changes Jul 2, 2024
View reviewed changes
petric.py Outdated Show resolved Hide resolved
petric.py Outdated Show resolved Hide resolved
casperdcl
casperdcl requested changes Jul 2, 2024
View reviewed changes
petric.py Outdated Show resolved Hide resolved
@KrisThielemans
Copy link
Member Author

As the full Action actually doesn't run, I guess we don't really know if this works or not. @casperdcl, save to merge after the check succeeds?

@casperdcl casperdcl merged commit 99266c6 into main Jul 2, 2024
2 checks passed
@casperdcl casperdcl deleted the get_data_fixes branch July 2, 2024 22:23
@casperdcl casperdcl added the data label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl requested changes

Assignees
No one assigned
Labels
data enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import petric reads all data and other comments
2 participants
@KrisThielemans @casperdcl