add FOV_mask to Dataset #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrisThielemans
force-pushed
the
FOV_mask
branch
5 times, most recently
from
82594eb
to
2b5c46f
Compare
|
My attempts to do a CI check are still failing due to various things such as #117. Now that I have the data, it seems to load it from somewhere else... |
KrisThielemans
force-pushed
the
FOV_mask
branch
2 times, most recently
from
b148354
to
d67bd30
Compare
|
Had to fix #118 due to changes in |
|
@casperdcl this is done now. The only complication was CI. This now downloads the Siemens_mMR_NEMA_IQ dataset and does some minimal checks on the images returned by However, I'm not sure if this change breaks your strategy for evaluation of contributions as CI no longer overwrites If you like, we can keep the CI changes for later, but can we merge the change to |
|
I need to merge this so will remove the CI commits |
KrisThielemans
force-pushed
the
FOV_mask
branch
from
d67bd30
to
0eb98be
Compare
Open
casperdcl
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_data()now provides an extra memberFOV_maskthat gives the FOV of the projector. This can be used to find which voxels can be non-zero. However, ignoring this mask is safe as VOIs are all well "within" it.fixes #47, see there for more discussion.
@gschramm, if you need it, you could use this now.