Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main.py needs updating #19

Closed
KrisThielemans opened this issue Jun 26, 2024 · 0 comments · Fixed by #20
Closed

main.py needs updating #19

KrisThielemans opened this issue Jun 26, 2024 · 0 comments · Fixed by #20
Assignees
@casperdcl

Comments

@KrisThielemans
Copy link
Member

This currently doesn't make any sense yet. For instance, it subclasses from GD.

PETRIC/main.py

Line 21 in bd28698

class Submission(GD):

I'm rather lost here. Possibly the Submission class should contain the reading of the data, and construction of prior, see #16 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

main (submission) & petric (backend) framework SyneRBI/PETRIC
2 participants
@KrisThielemans @casperdcl