device module unit tests #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added @CoreRasurae as a reviewer so he can also contribute any comments as this PR develops. |
|
@yana2301 Hi Yana, I've seen you've removed some integration tests that seem relevant to me... I know they aren't unit tests, but still, integration tests are also useful. |
|
@yana2301 I agree with @CoreRasurae . Several tests were removed that were working well. |
|
@yana2301 Hi Iana, please tell me when you have this PR ready for reviewing. I will also want to know your plans regarding the deleted tests. |
# Conflicts: # src/test/java/com/aparapi/device/JavaDeviceTest.java # src/test/java/com/aparapi/device/OpenCLDeviceGetArgsTest.java # src/test/java/com/aparapi/device/OpenCLDeviceTest.java # src/test/java/com/aparapi/device/OpenCLInvocationHandlerTest.java # src/test/java/com/aparapi/device/Utils.java # src/test/java/com/aparapi/internal/kernel/Utils.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.