Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ URGENT ][ AGAIN ] Syncano-core update method returns dict on reference #61

Closed
aexol opened this issue Dec 15, 2017 · 13 comments
Closed

[ URGENT ][ AGAIN ] Syncano-core update method returns dict on reference #61

aexol opened this issue Dec 15, 2017 · 13 comments
Labels
CORE FEATURE

Comments

@aexol
Copy link

aexol commented Dec 15, 2017

@Idered

{type: "reference", target: "article", value: 6988}
@Idered
Copy link
Member

Idered commented Dec 15, 2017

Expanding references and relations is not implemented for create and update methods.

@aexol
Copy link
Author

aexol commented Dec 17, 2017

Nooo its a bug not feature! it should return just

6988

Thats how its implemented in syncano-server
@Idered

@aexol
Copy link
Author

aexol commented Dec 17, 2017

It should never expand references as this would be too big cost for database.

@Idered
Copy link
Member

Idered commented Dec 18, 2017

@aexol can you please provide full query and version of syncano-server/syncano-core you use?

@aexol
Copy link
Author

aexol commented Dec 18, 2017

latest syncano-core

await data.mymodel.update({mydata})

@aexol
Copy link
Author

aexol commented Dec 18, 2017

@Idered

@Idered
Copy link
Member

Idered commented Dec 20, 2017

@aexol this should be resolved in latest @syncano/core@canary

@Idered
Copy link
Member

Idered commented Dec 21, 2017

@aexol does it work for you?

@aexol
Copy link
Author

aexol commented Dec 28, 2017 

	"dummyowner": {
		"type": "reference",
		"target": "user",
		"value": 2
	},

nope

@aexol
Copy link
Author

aexol commented Dec 28, 2017 

	"file": {
		"type": "file",
		"value": "https://d3rij3t703q5l6.cloudfront.net/31451/2/cb8166d4f0baf25b3ce03d4534c04bb1fe49281c.jpg"
	},

@aexol
Copy link
Author

aexol commented Dec 28, 2017

@Idered

@aexol
Copy link
Author

aexol commented Dec 28, 2017

update method

mkucharz added a commit that referenced this issue Jan 16, 2018
@mkucharz
fix(): #61 (#74)
8f8b83d 
* refactor()

* fix(tests): fixing unit tests

* fix(users): unnecessery proxy

* chore(): making `Server` a class

* fix(): case when first is generating error

* refactor(): adding debug, refactoring tests

* chore(): cleaning up

* chore(tests)

* refactor(): tests, small fixes

* fix(): after merge

* fix(cli-e2e)
mkucharz added a commit that referenced this issue Jan 16, 2018
@mkucharz
Revert "fix(): #61 (#74)"
bedcfed 
This reverts commit 8f8b83d.
mkucharz added a commit that referenced this issue Jan 16, 2018
@mkucharz
fix(): #61 additional (#75)
9276fe1 
* fix(): small fixes, removing unnecessary comments etc.
@aexol
Copy link
Author

aexol commented Jan 23, 2018

done

@aexol aexol closed this as completed Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CORE FEATURE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Idered @aexol