-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify implementation #56
Merged
Nyholm
merged 23 commits into
SymfonyTest:master
from
chapterjason:feature/simplification
Aug 24, 2021
Merged
Simplify implementation #56
Nyholm
merged 23 commits into
SymfonyTest:master
from
chapterjason:feature/simplification
Aug 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Renamed AppKernel to TestKernel to make it more obvious what the kernel is used for.
BREAKING CHANGE: Renamed addConfigFile to addConfig cause it also takes a closure to allow configuration with the Symfony\Component\DependencyInjection\ContainerBuilder
BREAKING CHANGE: Renamed setRoutingFile to addRoutingFile to allow multiple routing files
The rootDir is already deprecated lower than symfony 4.4, no need to support.
This resolves symlinks that might be used in systems like MacOS
BREAKING CHANGE: Renamed addCompilerPasses to addCompilerPass, this also changed the signature to single compiler passes only.
…e static property
Nyholm
approved these changes
Aug 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
I like this.
Im happy to merge this now and then update readme and properties/methods in another PR.
Thank you |
This was referenced Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of the most important changes (From the commits but without Fix CS stuff commits.):
BREAKING CHANGE: Renamed addCompilerPasses to addCompilerPass, this also changed the signature to single compiler passes only.
BREAKING CHANGE: Renamed setRoutingFile to addRoutingFile to allow multiple routing files
BREAKING CHANGE: Renamed addConfigFile to addConfig cause it also takes a closure to allow configuration with the
Symfony\Component\DependencyInjection\ContainerBuilder
BREAKING CHANGE: Renamed AppKernel to TestKernel to make it more obvious what the kernel is used for.
This resolves symlinks that might be used in systems like MacOS
The rootDir is already deprecated lower than symfony 4.4, no need to support.
Propery and method names
I also thought about changing the properties something like:
This will ensure they will, should, never conflict, and it helps while maintaining to differ between Symfony properties and own properties.
Also for the related methods I would prefix them like
addTestRoutingFile
, also this in the public api makes it more obvious for the developers what they are working with.WDYT?
Readme
Theres still that mention in the readme, I don't think that this will still be compatible.
I think we could also refactor a lot there to traits like
ContainerAssertionsTrait
Also for the ConfigTest package.
Related to #55