Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why was PublicServicePass removed in v2? #72

Closed
loevgaard opened this issue Oct 11, 2022 · 4 comments · May be fixed by #76
Closed

Why was PublicServicePass removed in v2? #72

loevgaard opened this issue Oct 11, 2022 · 4 comments · May be fixed by #76
Labels
question

Comments

@loevgaard
Copy link
Contributor

Thanks for this great package 🎉

Why was https://github.com/SymfonyTest/symfony-bundle-test/blob/1.x/src/CompilerPass/PublicServicePass.php removed in v2? If I want to test services that are only used by users of the bundle they are removed by default in Symfony and hence I cannot test them using this package. If I mark them public with the old PublicServicePass then I can.

Can you elaborate on this? Am I missing something? :)
@chapterjason
Copy link
Contributor

Hey @loevgaard, it was removed in #48 as Symfony provides the test.service_container which gives you access to private services.

https://symfony.com/doc/current/testing.html#retrieving-services-in-the-test

@loevgaard
Copy link
Contributor Author

Hi, @chapterjason

Yes, but it doesn't give me access to removed services. See https://github.com/symfony/symfony/blob/6.2/src/Symfony/Bundle/FrameworkBundle/Test/TestContainer.php#L19-L23

@chapterjason
Copy link
Contributor

Yes, that is right.

If you need to test private services that have been removed (those who are not used by any other services), you need to declare those private services as public in the config/services_test.yaml file.

IMO It is better to explicitly set only the neccessary services public in a separate file and load it with addTestConfig.

@loevgaard
Copy link
Contributor Author

That may be right. I find it easier to do with the compiler pass, but yes your way is more explicit. Thanks for your quick response!

@loevgaard loevgaard closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2022
@loevgaard loevgaard mentioned this issue Feb 21, 2023
Open
@sorrx sorrx mentioned this issue Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add instructions about testing unused private services loevgaard/symfony-bundle-test
2 participants
@chapterjason @loevgaard