Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes implicit dependency on sebastian/exporter #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

removes implicit dependency on sebastian/exporter #159

wants to merge 1 commit into from

Conversation

ju1ius
Copy link

@ju1ius ju1ius commented Feb 15, 2024

Closes #158

Nyholm
Nyholm approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

mbabker
mbabker requested changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@mbabker mbabker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break PHPUnit 11 support since Constraint::exporter() is removed.

It looks like PHPUnit\Util\Exporter is available for both 10.5 and 11.x and should avoid the scoping issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbabker mbabker mbabker requested changes

@Nyholm Nyholm Nyholm approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not work with phpunit phar release
3 participants
@ju1ius @mbabker @Nyholm