Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @coversNothing annotation to prevent raising risky warnings in PHPUnit 9.2 #129

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Jun 12, 2020

PHPUnit added a warning when a test method is missing @covers* annotation and one is using forceCoversAnnotation config: sebastianbergmann/phpunit#4246 .

Running the tests on PHPUnit 9.2 without this results in:

33) App\MyCompilerPass::compilation_should_not_fail_with_empty_container
This test does not have a @covers annotation but is expected to have one

Since this test method is final, we cannot override it in our project, so this is the best way to fix this.

@emodric
Copy link
Contributor Author

emodric commented Jun 18, 2020

Hi!

Can anyone take a look at this? Thanks!

@emodric
Copy link
Contributor Author

emodric commented Jun 29, 2020

@Nyholm Can you take a look at this, please?

Thanks!

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 72898ed into SymfonyTest:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants